Comments on: Reading GET variables with JavaScript http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/ a blog about building stuff on the web Mon, 09 Jan 2012 18:55:04 +0000 hourly 1 http://wordpress.org/?v=3.3 By: JRO http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-4569 JRO Wed, 14 Dec 2011 06:00:35 +0000 http://www.onlineaspect.com/?p=291#comment-4569 This works better: function getQueryVariable(variable) { var query = window.location.search.substring(1); var vars = query.split("&"); for (var i = 0; i < vars.length; i++) { var pair = vars[i].split("="); if (pair[0] == variable) { return unescape(pair[1]); } } return false; } This works better:

function getQueryVariable(variable) {
var query = window.location.search.substring(1);
var vars = query.split("&");
for (var i = 0; i < vars.length; i++) {
var pair = vars[i].split("=");
if (pair[0] == variable) {
return unescape(pair[1]);
}
}
return false;
}

]]> By: jerel http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-4565 jerel Tue, 13 Dec 2011 21:34:11 +0000 http://www.onlineaspect.com/?p=291#comment-4565 not to lurk, been trying to get this to do anything for hours now. Before i grind my teeth into dust, could someone be so kind as to show any of this working in context? say like <a href="http://www.whatever.com/index.php?var1=hi" rel="nofollow">www.whatever.com/index.php?var1=hi</a> is the url then the page w the script outputs var1 and prints hi? I know php well, new to js, getting a tad crazy over here... not to lurk, been trying to get this to do anything for hours now. Before i grind my teeth into dust, could someone be so kind as to show any of this working in context?

say like http://www.whatever.com/index.php?var1=hi is the url
then the page w the script outputs var1 and prints hi?

I know php well, new to js, getting a tad crazy over here…

]]> By: tomasz http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-3083 tomasz Thu, 12 May 2011 07:24:15 +0000 http://www.onlineaspect.com/?p=291#comment-3083 Don't you prefer? s = s || window.location.search; over s = s ? s : window.location.search; Don't you prefer?
s = s || window.location.search;
over
s = s ? s : window.location.search;

]]> By: Alex http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-3060 Alex Sat, 30 Apr 2011 15:18:06 +0000 http://www.onlineaspect.com/?p=291#comment-3060 Yep, it doesn't work without escaping the question mark. Maybe backslashes are autoremoved from the code section as well Yep, it doesn't work without escaping the question mark.
Maybe backslashes are autoremoved from the code section as well

]]> By: Marty http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-3072 Marty Thu, 28 Apr 2011 01:48:03 +0000 http://www.onlineaspect.com/?p=291#comment-3072 You're a god!!! hehehehe, you found the solution, you escaped the question mark 'cause it is a reserved word of regular expressions!! You're a god!!! hehehehe, you found the solution, you escaped the question mark 'cause it is a reserved word of regular expressions!!

]]> By: @Zakoholic http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-2934 @Zakoholic Wed, 09 Feb 2011 00:22:02 +0000 http://www.onlineaspect.com/?p=291#comment-2934 I think I can answer this myself because it seems like the backslash isn't shown in the comments section (not sure about your initial post). The line of code in my initial comment should read: return (s=s.replace(/^BACKSLASH?/,'&')... With 'BACKSLASH' being a real backslash. I think I can answer this myself because it seems like the backslash isn't shown in the comments section (not sure about your initial post). The line of code in my initial comment should read:

return (s=s.replace(/^BACKSLASH?/,'&')…

With 'BACKSLASH' being a real backslash.

]]> By: @Zakoholic http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-2933 @Zakoholic Tue, 08 Feb 2011 21:43:23 +0000 http://www.onlineaspect.com/?p=291#comment-2933 Thanks for this helpful function! One thing I'd like to mention is, that I got the same error message as the FettesPS but when I tried his suggestion of replacing the slashes with single quotes it wasn't working (probably because '^?' indicates it's a string). So I tried to escape the question mark with a backslash and now that the line looks like: return (s=s.replace(/^?/,'&')... it's working as it should. As I'm a JS newbie I'd like to know why I had to escape the ?, when it was apparently working fine for you (and Kip) without doing so. Thanks for this helpful function! One thing I'd like to mention is, that I got the same error message as the FettesPS but when I tried his suggestion of replacing the slashes with single quotes it wasn't working (probably because '^?' indicates it's a string). So I tried to escape the question mark with a backslash and now that the line looks like:

return (s=s.replace(/^?/,'&')…

it's working as it should. As I'm a JS newbie I'd like to know why I had to escape the ?, when it was apparently working fine for you (and Kip) without doing so.

]]> By: FettesPS http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-2803 FettesPS Thu, 03 Feb 2011 01:01:12 +0000 http://www.onlineaspect.com/?p=291#comment-2803 Was getting "invalid identifier ?" as an error and it pointed to "s.replace(/^?/,'&')" Had to replace the /'s with single quotes, making the line look like: s.replace('^?','&') After that it worked great! Was getting "invalid identifier ?" as an error and it pointed to "s.replace(/^?/,'&')"

Had to replace the /'s with single quotes, making the line look like:

s.replace('^?','&')

After that it worked great!

]]> By: Josh Fraser http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-2046 Josh Fraser Fri, 14 Jan 2011 21:00:48 +0000 http://www.onlineaspect.com/?p=291#comment-2046 I like it. Updated my code and added attribution for you as well. I like it. Updated my code and added attribution for you as well.

]]> By: kip http://www.onlineaspect.com/2009/06/10/reading-get-variables-with-javascript/comment-page-1/#comment-2045 kip Fri, 14 Jan 2011 20:44:50 +0000 http://www.onlineaspect.com/?p=291#comment-2045 One other change I'd recommend: differentiate between parameter that is defined but empty string and a parameter that isn't defined at all. To do this you'd have to change the regex and the return line: function $_GET(q,s) { s = s ? s : window.location.search; var re = new RegExp('&'+q+'(?:=([^&]*))?(?=&|$)','i'); return (s=s.replace(/^?/,'&').match(re)) ? (typeof s[1] == 'undefined' ? '' : decodeURIComponent(s[1])) : undefined; } Or to make it a little more verbose, if desired: function $_GET(q,s) { s = s ? s : window.location.search; var re = new RegExp('&'+q+'(?:=([^&]*))?(?=&|$)','i'); s = s.replace(/^?/,'&').match(re); if(s) return typeof s[1] != 'undefined' ? decodeURIComponent(s[1]) : ''; } Examples: $_GET('abc', '?abc=123&def=456') => Returns '123' $_GET('abc', '?abc=&def=456') => Returns '' $_GET('abc', '?abc&def=456') => Returns '' $_GET('abc', '?def=456') => In your code, returns ''. With my modification, returns undefined. One other change I'd recommend: differentiate between parameter that is defined but empty string and a parameter that isn't defined at all. To do this you'd have to change the regex and the return line:

function $_GET(q,s) {
s = s ? s : window.location.search;
var re = new RegExp('&'+q+'(?:=([^&]*))?(?=&|$)','i');
return (s=s.replace(/^?/,'&').match(re)) ? (typeof s[1] == 'undefined' ? '' : decodeURIComponent(s[1])) : undefined;
}

Or to make it a little more verbose, if desired:

function $_GET(q,s) {
s = s ? s : window.location.search;
var re = new RegExp('&'+q+'(?:=([^&]*))?(?=&|$)','i');
s = s.replace(/^?/,'&').match(re);
if(s)
return typeof s[1] != 'undefined' ? decodeURIComponent(s[1]) : '';
}

Examples:
$_GET('abc', '?abc=123&def=456') => Returns '123'
$_GET('abc', '?abc=&def=456') => Returns ''
$_GET('abc', '?abc&def=456') => Returns ''
$_GET('abc', '?def=456') => In your code, returns ''. With my modification, returns undefined.

]]>