Comments on: Auto detect a time zone with JavaScript

By: hkl

hkl — Tue, 02 Mar 2010 11:08:06 +0000

Hi Josh,

really great work! I found 2 little bugs: in the convert function you have to take the absolute value of minutes to find the correct index. Then you will get the correct timezone for Newfoundland. And I think the entry for Tehran must be set to dst, right?

By: Josh Fraser

Josh Fraser — Mon, 22 Feb 2010 06:23:52 +0000

Notice the comment I put at the bottom "As with anything that I post on this blog, feel free to use this code however you want. Just don’t blame me if it breaks."

Since then I have started releases everything under the Apache 2.0 license.

By: dothebart

dothebart — Sun, 21 Feb 2010 23:04:21 +0000

Hey Josh,
this looks like a very useable piece of js.
Since you posted it here, your intention probably is to share this and let others make use of this, right?
As you put just your name over it, gerenal copyright applies and one wouldn't legaly be able to use or redistribute it.
Most probably something like the BSD license would be appropriate for this work?
http://opensource.org/licenses/bsd-license.php

By: guest

guest — Sat, 13 Feb 2010 18:33:59 +0000

I have also verified that the script does break if you set your computer timezone to Newfoundaland.

By: sydney

sydney — Fri, 05 Feb 2010 16:31:32 +0000

How do you go about solving the issue where you have multiple time zones with same offset and dst. I want to be able to uniquely identify the timezones.

By: Zhibin

Zhibin — Fri, 18 Dec 2009 02:32:44 +0000

I found that you are actually using the date of July 1st to compare with January 1st, instead of using June 1st as you claimed. Although this has no impact on the end result, I would just like to point it out so that you may update your blog to correct it.

Here is the javascript code of yours:
var june1 = new Date(rightNow.getFullYear(), 6, 1, 0, 0, 0, 0); // june 1st

"6" actually means July here, because the parameter for the month starts with 0 for January and ends with 11 for December.

Zhibin

By: @yuricake

@yuricake — Sat, 07 Nov 2009 19:08:10 +0000

I don't understand why you need to create two dates and subtract them – wouldn't the internal Date engine just use the timezoneOffset to figure out the difference? In other words, what you are doing is the equivalent of taking jan1.getTimezoneOffset() and jun1.getTimezoneOffset(), no? can you give an example where the results of those two function calls is different from your code?

By: Josh Fraser

Josh Fraser — Wed, 21 Oct 2009 07:01:40 +0000

Awesome. Glad to hear it.

By: venkat

venkat — Wed, 21 Oct 2009 07:00:13 +0000

Thanks… awesome script.. saved a lot of my time

By: jana

jana — Fri, 02 Oct 2009 16:19:30 +0000

Thanks lot. Nice script.